From 64374fd4e7babd0cd5573164a830769605aeb193 Mon Sep 17 00:00:00 2001 From: HapeLee <63206378+HapeLee@users.noreply.github.com> Date: Sat, 25 Apr 2026 20:22:04 +0800 Subject: [PATCH] =?UTF-8?q?[=E6=96=B0=E5=A2=9E]=20=E9=80=82=E7=94=A8?= =?UTF-8?q?=E4=BA=8E=20Codex=20=E7=9A=84=E6=9C=89=E5=85=B3=E8=BF=81?= =?UTF-8?q?=E7=A7=BB=E5=92=8C=E5=AE=A1=E6=9F=A5=E7=9A=84=E7=9B=B8=E5=85=B3?= =?UTF-8?q?=20skill?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../skills/legado-compose-migration/SKILL.md | 69 +++++++ .../agents/openai.yaml | 4 + .../references/project-patterns.md | 172 ++++++++++++++++++ .codex/skills/legado-compose-review/SKILL.md | 59 ++++++ .../legado-compose-review/agents/openai.yaml | 4 + .../references/review-checklist.md | 117 ++++++++++++ 6 files changed, 425 insertions(+) create mode 100644 .codex/skills/legado-compose-migration/SKILL.md create mode 100644 .codex/skills/legado-compose-migration/agents/openai.yaml create mode 100644 .codex/skills/legado-compose-migration/references/project-patterns.md create mode 100644 .codex/skills/legado-compose-review/SKILL.md create mode 100644 .codex/skills/legado-compose-review/agents/openai.yaml create mode 100644 .codex/skills/legado-compose-review/references/review-checklist.md diff --git a/.codex/skills/legado-compose-migration/SKILL.md b/.codex/skills/legado-compose-migration/SKILL.md new file mode 100644 index 000000000..44cd62edb --- /dev/null +++ b/.codex/skills/legado-compose-migration/SKILL.md @@ -0,0 +1,69 @@ +--- +name: legado-compose-migration +description: Guide Legado Android UI migration from XML/View/RecyclerView/DialogFragment screens to Jetpack Compose and Material 3, and guide new Compose-first screens using standard Android architecture. Use when Codex is asked to create, migrate, rewrite, review, or plan a Legado screen, Activity, Fragment, dialog, adapter, navigation destination, or settings page, especially when MainActivity navigation, MVI/UDF, StateFlow, Koin ViewModels, domain/usecase boundaries, or existing Compose component conventions matter. +--- + +# Legado Compose Migration + +## Overview + +Migrate one UI surface at a time, or create one new Compose destination at a time. Preserve behavior first for migrations; for newly created screens, prefer standard modern Android architecture over mixed legacy patterns. Use the project's existing `MainActivity` navigation, `BaseComposeActivity` compatibility hosts, `*Screen`, `*Contract`, `*ViewModel`, `StateFlow`, `SharedFlow`, Koin, theme, and widget patterns. + +Before editing, inspect the target View implementation if one exists, `MainActivity` navigation when adding a destination, and at least two nearby migrated Compose screens. For concrete project patterns, read `references/project-patterns.md`. + +## Workflow + +1. State assumptions and success criteria. + - Name the exact screen or destination being created/migrated. + - For migrations, define behavior that must remain unchanged: inputs, result codes, navigation, menu actions, dialogs/sheets, list selection, refresh, persistence, and event bus behavior. + - For new screens, define the route owner, UI state, events/effects, domain/usecase boundary, and verification target. + - If the target mixes UI and business logic heavily, keep the migration surgical and defer deeper domain cleanup unless needed. + +2. Map the old surface. + - For migrations, read the Activity/Fragment, XML layouts, adapters, menu XML, dialogs, result launchers, and ViewModel. + - For new screens, read `MainActivity`, nearby route screens, the relevant ViewModel/usecase/repository patterns, and shared UI components. + - List UI state, user intents, one-shot effects, and external side effects. + - Identify reusable Compose components under `ui/widget/components` before creating new components. + +3. Choose the minimal migration shape. + - For new Compose-first screens, add a `MainActivity` navigation destination instead of creating a standalone Activity. + - Use `BaseComposeActivity` for full-screen Activity migrations only when a legacy Activity must remain as an entry point. + - Keep existing Activity Result APIs, `Intent` extras, permission flows, and Android framework calls in the host/compatibility Activity. + - If an unreworked View screen still starts the migrated screen with `Intent`, keep the old Activity only as a compatibility host that parses legacy extras and delegates to the Compose screen or `MainActivity` route boundary. + - Put renderable state in `UiState`, user actions in `Intent`, and one-shot navigation/framework work in `Effect`. + - For new screens, use standard Android/Compose architecture: UDF/MVI-style state hoisting, lifecycle-aware Flow collection, ViewModel-owned state, repository/usecase boundaries, and UI free of business logic. + - Use mixed legacy patterns only as an integration boundary for unreworked View screens or existing framework contracts. + - Use existing repositories/usecases when they already fit; introduce new domain/usecase classes when a new screen needs clean business boundaries or when a migration would otherwise duplicate or entangle business logic. + +4. Implement by layers. + - Create or update `FeatureContract.kt` first for `UiState`, `Intent`, `Effect`, dialog/sheet models, and menu action enums. + - Update `FeatureViewModel.kt` to expose `uiState: StateFlow` and `effects: SharedFlow`, with a single `onIntent(...)` entry point unless the existing feature has a simpler established pattern. + - Create `FeatureScreen.kt` as a stateless route-level composable: `state`, callbacks, and `onIntent`. + - Wire new Compose destinations through `MainActivity` route handling; update a retained Activity only when legacy `Intent` compatibility is required. + - Collect state with `collectAsStateWithLifecycle()` and collect effects in `LaunchedEffect(Unit)` from the route or compatibility host. + - Register new ViewModels in `di/appModule.kt` with `viewModelOf(::FeatureViewModel)` unless parameters require `viewModel { ... }`. + +5. Remove only obsolete migration artifacts. + - Delete XML layouts, adapters, menu resources, binding fields, and imports only when the migrated screen no longer references them. + - Do not refactor unrelated View screens or shared utilities. + +6. Verify. + - Prefer the smallest Gradle check that compiles the touched app code, usually `.\gradlew.bat :app:compileAppDebugKotlin`. + - If resources, manifests, or XML deletion are involved, run `.\gradlew.bat :app:assembleAppDebug` when feasible. + - For behavior-heavy changes, add or update focused tests only where the project already has a practical test seam. + +## Boundaries + +- Keep Compose functions side-effect-light. Use `LaunchedEffect` for collecting effects and use callbacks for user actions. +- Do not pass `Activity`, `View`, binding objects, or mutable domain entities deep into composables unless an existing local pattern requires it. +- Prefer project theme/components: `LegadoTheme`, `AppScaffold`, `ListScaffold`, `AppAlertDialog`, `AppModalBottomSheet`, `RoundDropdownMenu`, top bar helpers, setting items, cover components, and list utilities. +- Prefer `StateFlow`/`SharedFlow` over `LiveData` for newly migrated Compose surfaces. +- When using `FeatureIntent` for MVI user actions, distinguish it from Android `Intent` extras and launch APIs in names, comments, and explanations where both appear. +- For new Compose-first screens, do not copy View-era shortcuts such as UI logic in Activity/Fragment, direct binding-like mutable UI state, adapter-owned state, or Activity-context business operations. +- Keep one-off Android actions out of `UiState`: navigation, file opening, clipboard, dialogs implemented as Android DialogFragments, result launchers, permission requests, and callbacks that require host context should be `Effect`s handled by `MainActivity` route handling or a compatibility Activity. +- Prefer `MainActivity` navigation for new Compose destinations. Treat standalone Activities for migrated screens as legacy entry points only when existing View code still depends on `Intent` navigation. +- Keep existing Chinese string resources and localization behavior; add strings to resources when user-facing text is new. + +## Reference + +Read `references/project-patterns.md` when implementing or reviewing a migration. It contains project-specific examples, file placement rules, state/effect conventions, and verification commands. diff --git a/.codex/skills/legado-compose-migration/agents/openai.yaml b/.codex/skills/legado-compose-migration/agents/openai.yaml new file mode 100644 index 000000000..57ec07b7f --- /dev/null +++ b/.codex/skills/legado-compose-migration/agents/openai.yaml @@ -0,0 +1,4 @@ +interface: + display_name: "Legado Compose Migration" + short_description: "Guide Legado Compose screens and migration" + default_prompt: "Use $legado-compose-migration to create or migrate a Legado Android Compose screen with MainActivity navigation and standard architecture." diff --git a/.codex/skills/legado-compose-migration/references/project-patterns.md b/.codex/skills/legado-compose-migration/references/project-patterns.md new file mode 100644 index 000000000..afaba4f58 --- /dev/null +++ b/.codex/skills/legado-compose-migration/references/project-patterns.md @@ -0,0 +1,172 @@ +# Legado Compose Migration Project Patterns + +## Existing Shape + +- App module: `app`. +- Main source root: `app/src/main/java/io/legado/app`. +- UI package: `ui/...`, usually grouped by feature. +- Data package: `data/dao`, `data/entities`, `data/repository`. +- Domain package: `domain/gateway`, `domain/model`, `domain/repository`, `domain/usecase`. +- DI: `di/appModule.kt`, using Koin `singleOf`, `viewModelOf`, and parameterized `viewModel { ... }`. +- Main navigation: `ui/main/MainActivity.kt`, using Navigation3 `NavKey`, `rememberNavBackStack`, `entryProvider`, and `NavDisplay`, plus legacy route extras such as `EXTRA_START_ROUTE`. +- Base Compose host: `base/BaseComposeActivity.kt`, which wraps `Content()` in `AppTheme`, configures system bars, locale/font, background image, and LiveBus recreation events. +- Compose dependencies are already enabled in `app/build.gradle.kts`; do not add new UI libraries unless the target screen truly requires one. + +## Files to Inspect Before Migrating + +Inspect these as local examples, not as APIs to copy blindly: + +- `ui/book/info/BookInfoActivity.kt` +- `ui/book/info/BookInfoContract.kt` +- `ui/book/info/BookInfoViewModel.kt` +- `ui/book/info/BookInfoScreen.kt` +- `ui/book/search/SearchContract.kt` +- `ui/book/search/SearchViewModel.kt` +- `ui/book/search/SearchScreen.kt` +- `ui/main/MainActivity.kt` +- `ui/main/MainScreen.kt` +- `ui/widget/components/AppScaffold.kt` +- `ui/widget/components/list/ListScaffold.kt` +- `ui/theme/LegadoTheme.kt` +- `ui/theme/AppTheme.kt` + +## Recommended Feature Layout + +For a migrated feature, prefer colocated files: + +```text +ui/// + FeatureActivity.kt # only for legacy Intent compatibility or full-screen migration host + FeatureContract.kt + FeatureViewModel.kt + FeatureScreen.kt + FeatureSheets.kt # only if sheets are substantial + FeatureDialogs.kt # only if dialogs are substantial +``` + +Use the smallest set of files. Do not split files just to match this shape. + +## MVI and UDF Rules + +Use this shape for behavior-heavy screens: + +```kotlin +data class FeatureUiState( + val isLoading: Boolean = false, + val items: List = emptyList(), + val dialog: FeatureDialog? = null, + val sheet: FeatureSheet = FeatureSheet.None, +) + +sealed interface FeatureIntent { + data object BackPressed : FeatureIntent + data object Refresh : FeatureIntent + data class ItemClick(val id: Long) : FeatureIntent +} + +sealed interface FeatureEffect { + data object Finish : FeatureEffect + data class OpenDetail(val id: Long) : FeatureEffect +} +``` + +ViewModel rules: + +- Keep `_uiState = MutableStateFlow(FeatureUiState())` private and expose `uiState = _uiState.asStateFlow()`. +- Keep `_effects = MutableSharedFlow(extraBufferCapacity = 8)` private and expose `effects = _effects.asSharedFlow()`. +- Prefer `fun onIntent(intent: FeatureIntent)` as the UI entry point. +- Treat `FeatureIntent` as an MVI/user-action type. When Android `Intent` launch/extras are also involved, name variables and explanations clearly enough that the two concepts are not confused. +- Use `_uiState.update { it.copy(...) }` for state changes. +- Emit one-shot work through effects, not booleans in state. +- Keep cached current entities private in the ViewModel when existing project behavior needs mutation or incremental sync, but publish immutable render state. +- Use existing `BaseViewModel.execute { ... }.onSuccess { ... }.onError { ... }` when the surrounding ViewModel already uses that pattern. + +Activity rules: + +- Prefer `MainActivity` as the owner of Compose-first navigation. Add a Navigation3 route/key and `entryProvider` entry there for new destinations. +- Extend `BaseComposeActivity` for migrated Activity screens only when a standalone Activity remains necessary. +- Keep a legacy Activity for a migrated screen only when unreworked View code still calls it through `Intent`; in that case, make the Activity a thin compatibility host that translates extras/results and delegates to Compose state/effects. +- Keep Activity Result launchers, file openers, clipboard, permission APIs, Android DialogFragments, and framework navigation in the Activity. +- In `Content()`, collect state with `collectAsStateWithLifecycle().value`. +- Collect effects in `LaunchedEffect(Unit) { viewModel.effects.collectLatest { ... } }`. +- Pass only `state` and callbacks into the screen. + +Navigation rules: + +- For new Compose-first destinations, add the route to `MainActivity` instead of adding a new Activity. +- Follow `MainActivity`'s current route style: serializable `NavKey` routes for in-process navigation and launcher `Intent` helper methods only when external or legacy callers need a stable entry point. +- Keep legacy extra names stable when replacing an old Activity entry point. +- When a compatibility Activity is retained, let it translate old `Intent` inputs/results; do not make it the source of truth for navigation or business behavior. + +Screen rules: + +- Make `FeatureScreen(state, onIntent, ...)` stateless for business state. +- Use `remember` and `rememberSaveable` only for local UI affordances such as menu expansion, scroll state, transient animation state, and text field drafts when committing through an intent. +- Use `BackHandler` to route back actions through `FeatureIntent.BackPressed` when ViewModel decisions matter. +- Keep expensive derived values in `remember(key)` or ViewModel state when they depend on repository data. +- Prefer `LazyColumn`, `LazyRow`, stable keys, and existing fast-scroller/list components for adapter migrations. + +## Clean Architecture Boundaries + +This project is mid-migration, so use Clean Architecture pragmatically. For newly created screens, default to standard modern Android architecture and avoid mixed legacy patterns unless they are needed to interoperate with View screens that have not been rewritten. + +- For new screens, keep UI, presentation, domain, and data boundaries explicit: Compose renders state, ViewModel owns state and intent handling, usecases hold reusable business actions, repositories mediate data access. +- For new screens, do not place business rules in Activity/Fragment or composables. +- For new screens, do not read DAOs directly from UI/presentation unless the project already has no reasonable repository/usecase boundary and adding one would be disproportionate. +- For migrations, use existing DAOs/repositories directly if the old ViewModel already does and the migration is UI-only. +- Prefer existing `domain/usecase` classes for reusable business actions such as cache, delete, group update, startup maintenance, reading progress, and WebDAV flows. +- Add a usecase when a new screen has meaningful business rules, when logic would otherwise be duplicated across features, or when a UI migration needs to extract meaningful business rules from an Activity/adapter. +- Keep UI-only formatting and Compose layout decisions out of domain. +- Keep entity-to-display mapping near the UI or ViewModel unless it is reused business language. + +## Compose Components and Theme + +Prefer project components before raw Material widgets: + +- Scaffold/top bars: `AppScaffold`, `GlassTopAppBar...`, `DynamicTopAppBar`, `TopBarActionButton`, `TopBarNavigationButton`. +- Lists: `ListScaffold`, `TopFloatingStickyItem`, `VerticalFastScroller`, `SelectionBottomBar`. +- Dialog/sheet: `AppAlertDialog`, `AppModalBottomSheet`, `OptionSheet`, text list input components. +- Settings: `ClickableSettingItem`, `SwitchSettingItem`, `SliderSettingItem`, `ListSettingItem`, `SettingCard`. +- Buttons/chips: `AppIconButton`, `SmallIconButton`, `SmallTextButton`, `ToggleChip`, `AlertButton`. +- Covers/images: `CoilBookCover`, `BookshelfCover`, `buildCoverImageRequest`; use Coil for Compose image loading. +- Theme: `LegadoTheme.colorScheme`, `LegadoTheme.typography`, `ThemeResolver`, `ProvideThemeOverride` where existing feature behavior needs theme override. + +Avoid introducing a second visual system. If a raw Material 3 component is used, style it from `LegadoTheme`. + +## Migration Checklist + +Before editing: + +- Identify old XML layouts, ViewBinding fields, adapters, decorations, menu XML, dialogs, and result contracts. +- Capture behavior: empty/loading/error states, refresh, search, sort, selection, long click, swipe, menu actions, back behavior, result codes, events, and persisted preferences. +- Decide whether the task is UI-only or needs domain extraction. +- For new screens, explicitly decide the presentation/domain/data boundary before coding; do not default to legacy mixed architecture. + +During editing: + +- Create/update `Contract`, then `ViewModel`, then `Screen`, then `MainActivity` route or compatibility host. +- For new Compose destinations, wire navigation through `MainActivity` unless a legacy `Intent` caller must remain supported. +- When retaining an Activity for compatibility, keep it small: parse legacy extras, collect effects, bridge result codes, and avoid placing feature business logic there. +- Reuse existing string resources and add new resources for new user-facing text. +- Register the ViewModel in `di/appModule.kt`. +- Remove only resources made obsolete by this migration. +- Keep existing public intent extra names and result codes unless explicitly changing an API. + +Verification: + +- Run `.\gradlew.bat :app:compileAppDebugKotlin` for Kotlin-only changes. +- Run `.\gradlew.bat :app:assembleAppDebug` when resources, manifests, XML deletion, or generated bindings are affected. +- If a screen uses Room queries or migration-sensitive repositories, run the relevant existing Android/unit tests if practical. +- For manual verification, open the migrated screen and compare core flows against the old behavior list. + +## Common Pitfalls + +- Do not put navigation or Activity launchers inside composables. +- Do not store one-time navigation as nullable fields in `UiState` unless the existing local pattern already does; prefer `SharedFlow` effects. +- Do not keep adapter selection state split between old adapter and new Compose state. +- Do not delete XML/menu resources until all references and generated binding imports are gone. +- Do not add speculative domain layers for a single migrated screen. +- Do not use mixed architecture for new screens unless compatibility with unreworked View UI requires it. +- Do not make a migrated screen's retained Activity the primary navigation model when `MainActivity` can own the Compose destination. +- Do not bypass `BaseComposeActivity` unless the screen must remain inside a Fragment or legacy host. +- Do not replace existing event bus or service interactions as part of a UI migration unless required for correctness. diff --git a/.codex/skills/legado-compose-review/SKILL.md b/.codex/skills/legado-compose-review/SKILL.md new file mode 100644 index 000000000..3b016d859 --- /dev/null +++ b/.codex/skills/legado-compose-review/SKILL.md @@ -0,0 +1,59 @@ +--- +name: legado-compose-review +description: Review existing Legado Jetpack Compose code for architecture, behavior, maintainability, and project convention issues. Use when Codex is asked to audit, review, inspect, evaluate, or find problems in Legado Compose screens, routes, ViewModels, contracts, dialogs, sheets, navigation, or early Compose implementations, especially for MVI/UDF, StateFlow/SharedFlow, Clean Architecture, MainActivity navigation, legacy Activity compatibility, and View-era mixed-pattern drift. +--- + +# Legado Compose Review + +## Overview + +Review existing Compose code before rewriting it. Focus on concrete defects, architectural drift, behavior risks, and missing verification, especially in early Compose screens that may predate the current MVI/UDF, Clean Architecture, and `MainActivity` navigation expectations. + +Read `references/review-checklist.md` for the project-specific checklist and severity guidance. + +## Workflow + +1. Define the review scope. + - Identify the exact screen, route, ViewModel, contract, or package under review. + - State whether the user wants review only or review plus fixes. If unclear, review first and do not edit code. + - Treat unrelated legacy View code as context, not as part of the review, unless it affects the Compose surface. + +2. Build context from code. + - Read the `*Screen`, `*ViewModel`, `*Contract`, host Activity/route, DI registration, and any repositories/usecases used by the feature. + - Read the old View implementation only if it is still a compatibility caller or behavior reference. + - Compare against nearby current examples such as `BookInfo*`, `Search*`, `MainActivity`, and shared components under `ui/widget/components`. + +3. Review by risk, not style preference. + - Prioritize behavior regressions, state duplication, lifecycle bugs, navigation bugs, business logic in UI, direct data access from UI/presentation, recomposition hazards, and missing compatibility handling. + - Flag style-only issues only when they conflict with established project conventions or make future migration harder. + - Do not require broad refactors for a small screen unless the current code creates real behavior or maintenance risk. + +4. Output findings first. + - Use code-review style: list findings before summaries. + - Include file and tight line references. + - Explain the concrete impact and the smallest credible fix. + - If using Codex review directives, emit one `::code-comment{...}` per finding. + - If no issues are found, say that clearly and mention remaining test/manual verification gaps. + +5. Suggest fixes only after findings. + - Group fixes into small, reviewable steps. + - For architecture drift, separate compatibility-preserving fixes from larger cleanup. + - Recommend `legado-compose-migration` only when the finding implies a migration or rewrite workflow. + +## Review Priorities + +- **P0/P1**: behavior breakage, lost navigation/result behavior, unsafe lifecycle collection, stale state, data corruption, crashes, or compatibility entry points that no longer work. +- **P2**: architecture drift that will cause duplicated logic, hard-to-test behavior, recomposition bugs, or incorrect ownership of state/effects. +- **P3**: convention drift, maintainability issues, weak naming, missing previews/tests, or small cleanup that should not block behavior. + +## Boundaries + +- Do not rewrite code during a review unless the user asks for fixes. +- Do not demand pure architecture where a compatibility boundary is necessary for unreworked View screens. +- For new Compose-first code, expect standard Android architecture: `MainActivity` route ownership, ViewModel-owned state, UDF/MVI user actions, `StateFlow`/`SharedFlow`, repositories/usecases, and UI without business logic. +- For migrated code, allow a thin retained Activity only for Android `Intent` compatibility with unreworked View callers. +- Distinguish MVI `FeatureIntent` user actions from Android `Intent` launch/extras when both appear. + +## Reference + +Read `references/review-checklist.md` for detailed checks. When a review turns into implementation, also read `../legado-compose-migration/references/project-patterns.md` if available. diff --git a/.codex/skills/legado-compose-review/agents/openai.yaml b/.codex/skills/legado-compose-review/agents/openai.yaml new file mode 100644 index 000000000..91de901ae --- /dev/null +++ b/.codex/skills/legado-compose-review/agents/openai.yaml @@ -0,0 +1,4 @@ +interface: + display_name: "Legado Compose Review" + short_description: "Review Legado Compose architecture quality" + default_prompt: "Use $legado-compose-review to review a Legado Compose screen for MVI, UDF, Clean Architecture, navigation, and project convention issues." diff --git a/.codex/skills/legado-compose-review/references/review-checklist.md b/.codex/skills/legado-compose-review/references/review-checklist.md new file mode 100644 index 000000000..135344d0e --- /dev/null +++ b/.codex/skills/legado-compose-review/references/review-checklist.md @@ -0,0 +1,117 @@ +# Legado Compose Review Checklist + +## Files to Read + +For a feature review, inspect the smallest complete slice: + +- `FeatureScreen.kt` and any `FeatureSheets.kt` / `FeatureDialogs.kt`. +- `FeatureViewModel.kt`. +- `FeatureContract.kt` if present. +- Host route in `MainActivity.kt` or retained `FeatureActivity.kt`. +- Koin registration in `di/appModule.kt`. +- Repositories/usecases used by the feature. +- Old View caller or XML/adapters only when still used for compatibility or behavior comparison. + +Use current examples as references: + +- `ui/main/MainActivity.kt` for Navigation3 route ownership. +- `ui/book/info/BookInfoContract.kt`, `BookInfoViewModel.kt`, `BookInfoScreen.kt` for behavior-heavy MVI/UDF. +- `ui/book/search/SearchContract.kt`, `SearchViewModel.kt`, `SearchScreen.kt` for route-level search state. +- `ui/widget/components/...` and `ui/theme/...` for shared UI conventions. + +## Architecture Checks + +Flag issues when: + +- A new Compose-first screen is implemented as a standalone Activity instead of a `MainActivity` destination without a compatibility reason. +- A retained Activity contains feature business logic instead of acting as a thin Android `Intent` compatibility host. +- Business rules, repository calls, DAO calls, persistence writes, or service orchestration live in composables. +- ViewModel exposes mutable state directly, exposes `MutableStateFlow`, or lets UI mutate domain objects. +- UI state is split across Activity fields, composable `remember` state, adapter state, and ViewModel state in a way that can diverge. +- One-shot events such as navigation, result codes, file opening, permission requests, or clipboard writes are represented as persistent `UiState` fields that can replay incorrectly. +- MVI `FeatureIntent` user actions are confused with Android `Intent` launch/extras. +- Domain/usecase boundaries are bypassed in new screens when a meaningful business action exists. +- A migration introduces new domain abstractions for a single trivial UI action without reducing real complexity. + +## UDF and State Checks + +Flag issues when: + +- `Screen` functions own business state instead of receiving `state` and callbacks. +- `remember` / `rememberSaveable` stores source-of-truth data that should survive process or route recreation through ViewModel state. +- `LaunchedEffect` keys are unstable or cause repeated data loading, duplicate navigation, duplicate toasts, or repeated service calls. +- Flows are collected without lifecycle awareness in UI routes where `collectAsStateWithLifecycle()` should be used. +- List items lack stable keys where mutation, selection, or animation can make state attach to the wrong row. +- Selection, search query, sorting, filtering, loading, and error states are not represented in a single coherent `UiState`. +- Derived values are recomputed expensively on every recomposition instead of living in ViewModel state or `remember(key)`. + +## Navigation and Compatibility Checks + +Flag issues when: + +- New Compose destinations skip `MainActivity` Navigation3 route registration. +- Legacy Android `Intent` extras or result codes change without an explicit compatibility plan. +- A migrated screen is reachable both through `MainActivity` and a retained Activity with inconsistent state initialization. +- Navigation is performed directly inside nested composables instead of through callbacks/effects. +- Activity Result launchers, file pickers, permission requests, or Android DialogFragments are hidden inside reusable UI composables. +- Back behavior bypasses ViewModel decisions when unsaved changes, selection mode, add-to-shelf prompts, or confirmation dialogs exist. + +## UI and Project Convention Checks + +Flag issues when: + +- Raw Material components ignore `LegadoTheme` or existing shared components where the project already has a wrapper. +- A screen recreates shared UI already present under `ui/widget/components`. +- User-facing text is hardcoded instead of using string resources, except for temporary debug-only text. +- Compose UI keeps ViewBinding, adapter, or XML assumptions after migration. +- Dialogs and bottom sheets use inconsistent project components when `AppAlertDialog`, `AppModalBottomSheet`, or existing option sheets fit. +- Image loading bypasses existing Coil cover/image helpers where cover behavior, cache, SVG, or GIF handling matters. + +## Clean Architecture Checks + +For new screens, expect: + +- Compose renders state and emits user actions. +- ViewModel owns state, intent handling, and effect emission. +- Usecases own reusable business actions. +- Repositories mediate data access. +- DAOs remain behind repositories unless adding a boundary would be disproportionate and local project patterns already allow direct use. + +For migrated screens, allow pragmatic intermediate code only when: + +- It preserves behavior. +- It is isolated behind a clear compatibility boundary. +- It does not spread View-era assumptions into new Compose-first code. + +## Output Template + +Use this shape unless the user asks for another format: + +```text +Findings +- [P1] Title + file:line + Impact: ... + Fix: ... + +Open Questions +- ... + +Notes +- No issues found in ... / Tests not run ... +``` + +When using Codex inline review comments, emit one directive per finding with tight line ranges: + +```text +::code-comment{title="[P2] Keep route state in ViewModel" body="..." file="/absolute/path/FeatureScreen.kt" start=42 end=45 priority=2 confidence=0.8} +``` + +## Verification Suggestions + +Recommend verification based on the reviewed change: + +- Kotlin-only review/fix: `.\gradlew.bat :app:compileAppDebugKotlin`. +- Resource/XML/manifest impact: `.\gradlew.bat :app:assembleAppDebug`. +- Navigation or compatibility changes: manually open both `MainActivity` route and any retained legacy Android `Intent` entry point. +- Behavior-heavy ViewModel changes: add or run focused tests only where the project has a practical test seam.